[
https://issues.apache.org/jira/browse/FLINK-9735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16609097#comment-16609097
]
ASF GitHub Bot commented on FLINK-9735:
---------------------------------------
StefanRRichter commented on issue #6660: [FLINK-9735] Potential resource leak
in RocksDBStateBackend#getDbOptions
URL: https://github.com/apache/flink/pull/6660#issuecomment-419893355
Hi, the title of the PR is very misleading. This is not about any leak in
the backend, this is just about the test resource. I would recommend *not* to
ping many people for trivial changes like this PR, we can also see if you just
ping once but have to prioritize as well.
With that being said, thanks for the contribution and the PR looks good to
me 👍
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Potential resource leak in RocksDBStateBackend#getDbOptions
> -----------------------------------------------------------
>
> Key: FLINK-9735
> URL: https://issues.apache.org/jira/browse/FLINK-9735
> Project: Flink
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: vinoyang
> Priority: Minor
> Labels: pull-request-available
>
> Here is related code:
> {code}
> if (optionsFactory != null) {
> opt = optionsFactory.createDBOptions(opt);
> }
> {code}
> opt, an DBOptions instance, should be closed before being rewritten.
> getColumnOptions has similar issue.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
