tillrohrmann commented on a change in pull request #6678: [FLINK-10255] Only 
react to onAddedJobGraph signal when being leader
URL: https://github.com/apache/flink/pull/6678#discussion_r217068175
 
 

 ##########
 File path: 
flink-runtime/src/test/java/org/apache/flink/runtime/dispatcher/TestingDispatcher.java
 ##########
 @@ -80,9 +80,16 @@ void completeJobExecution(ArchivedExecutionGraph 
archivedExecutionGraph) {
        }
 
        @VisibleForTesting
-       public CompletableFuture<Void> getJobTerminationFuture(@Nonnull JobID 
jobId, @Nonnull Time timeout) {
+       CompletableFuture<Void> getJobTerminationFuture(@Nonnull JobID jobId, 
@Nonnull Time timeout) {
                return callAsyncWithoutFencing(
                        () -> getJobTerminationFuture(jobId),
                        timeout).thenCompose(Function.identity());
        }
+
+       @VisibleForTesting
 
 Review comment:
   You're right. Will change it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to