tillrohrmann commented on a change in pull request #6678: [FLINK-10255] Only
react to onAddedJobGraph signal when being leader
URL: https://github.com/apache/flink/pull/6678#discussion_r217068791
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
##########
@@ -861,14 +861,18 @@ public void grantLeadership(final UUID
newLeaderSessionID) {
getMainThreadExecutor());
}
- protected CompletableFuture<Void> getJobTerminationFuture(JobID jobId) {
+ CompletableFuture<Void> getJobTerminationFuture(JobID jobId) {
if (jobManagerRunners.containsKey(jobId)) {
return FutureUtils.completedExceptionally(new
DispatcherException(String.format("Job with job id %s is still running.",
jobId)));
} else {
return jobManagerTerminationFutures.getOrDefault(jobId,
CompletableFuture.completedFuture(null));
}
}
+ CompletableFuture<Void> getRecoveryOperation() {
Review comment:
Good point. Will add it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
