zhijiangW commented on issue #6697: [hotfix][benchmarks] Add network broadcast benchmark URL: https://github.com/apache/flink/pull/6697#issuecomment-421939190 I agree with your above points. 1. It is better to cover both of them, that means we cover most of the APIs from `RecordWriter` side. If necessary, I can submit a separate PR covering `BroadcastPartitioner` later. 2. I think your said is right. I just pointed out it because I did not see any tests for broadcast before. Your work supplements my previous PR, not duplicate with my work. :)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
