NicoK commented on a change in pull request #6692: [FLINK-10331][network]
reduce unnecesary flushing
URL: https://github.com/apache/flink/pull/6692#discussion_r218357314
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/io/network/partition/InputGateConcurrentTest.java
##########
@@ -198,6 +199,8 @@ public void testConsumptionWithMixedChannels() throws
Exception {
private abstract static class Source {
abstract void addBufferConsumer(BufferConsumer bufferConsumer)
throws Exception;
+
+ abstract void flush();
Review comment:
depending on the implementation in `PipelinedSubpartition`, i.e. `if
(buffers.size() == 1 && buffers.peekLast().isFinished())` or whatever we change
it to (we don't make guarantees here!), the producer thread may not have
flushed its last record after finishing and the source would wait forever (no
output flusher in that test)
-> we need to flush all channels before leaving the producer
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
