tillrohrmann commented on a change in pull request #6717: [FLINK-10369][tests] 
Enable YARNITCase to test per job mode deployment
URL: https://github.com/apache/flink/pull/6717#discussion_r219068565
 
 

 ##########
 File path: flink-yarn-tests/src/test/java/org/apache/flink/yarn/YARNITCase.java
 ##########
 @@ -79,20 +86,45 @@ public void testPerJobMode() throws Exception {
 
                        env.addSource(new InfiniteSource())
                                .shuffle()
-                               .addSink(new DiscardingSink<Integer>());
+                               .addSink(new DiscardingSink<>());
 
                        final JobGraph jobGraph = 
env.getStreamGraph().getJobGraph();
 
                        File testingJar = YarnTestBase.findFile("..", new 
TestingYarnClusterDescriptor.TestJarFinder("flink-yarn-tests"));
 
 Review comment:
   Good idea. I'll move `TestJarFinder` into `YarnTestUtils`. However, we 
cannot remove `TestingYarnClusterDescriptor` at the moment, because it is used 
by the `YARNHighAvailabilityITCase`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to