[
https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622103#comment-16622103
]
ASF GitHub Bot commented on FLINK-9713:
---------------------------------------
twalthr commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r219174337
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/calcite/RelTimeIndicatorConverter.scala
##########
@@ -442,11 +402,63 @@ class RexTimeIndicatorMaterializer(
// materialize function's result and operands
case _ if isTimeIndicatorType(updatedCall.getType) =>
- updatedCall.clone(timestamp, materializedOperands)
+ updatedCall.clone(materializerUtils.getTimestamp, materializedOperands)
// materialize function's operands only
case _ =>
updatedCall.clone(updatedCall.getType, materializedOperands)
}
}
}
+
+/**
+ * Helper class for shared logic of materializing time attributes in
[[RelNode]] and [[RexNode]].
+ */
+class RexTimeIndicatorMaterializerUtils(rexBuilder: RexBuilder) {
+
+ private val timestamp = rexBuilder
+ .getTypeFactory
+ .asInstanceOf[FlinkTypeFactory]
+ .createTypeFromTypeInfo(SqlTimeTypeInfo.TIMESTAMP, isNullable = false)
+
+ def getTimestamp: RelDataType = {
+ timestamp
+ }
+
+ def projectAndMaterializeFields(input: RelNode, indicesToMaterialize:
Set[Int]) : RelNode = {
+ val projects = input.getRowType.getFieldList.map { field =>
+ materializeIfContains(
+ new RexInputRef(field.getIndex, field.getType),
+ field.getIndex,
+ indicesToMaterialize)
+ }
+
+ LogicalProject.create(
Review comment:
Do we always want to add a project or should we check first if the project
is necessary? We are doing this in `convertAggregate`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Support versioned joins in planning phase
> -----------------------------------------
>
> Key: FLINK-9713
> URL: https://issues.apache.org/jira/browse/FLINK-9713
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.5.0
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: pull-request-available
>
> Queries like:
> {code:java}
> SELECT
> o.amount * r.rate
> FROM
> Orders AS o,
> LATERAL TABLE (Rates(o.rowtime)) AS r
> WHERE o.currency = r.currency{code}
> should evaluate to valid plan with versioned joins plan node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
