[
https://issues.apache.org/jira/browse/FLINK-9713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16622219#comment-16622219
]
ASF GitHub Bot commented on FLINK-9713:
---------------------------------------
pnowojski commented on a change in pull request #6299: [FLINK-9713][table][sql]
Support processing time versioned joins
URL: https://github.com/apache/flink/pull/6299#discussion_r219212679
##########
File path:
flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
##########
@@ -158,36 +158,60 @@ class Table(
/**
* Creates [[TemporalTableFunction]] backed up by this table as a history
table.
- *
- * @param timeIndicator field for the [[TemporalTableFunction]]. Must
points to a time indicator
- * @param primaryKey field for the [[TemporalTableFunction]].
- * @return [[TemporalTableFunction]]
+ * Temporal Tables represent a concept of a table that changes over time
and for which
+ * Flink keeps track of those changes. [[TemporalTableFunction]] provides a
way how to access
Review comment:
I would keep `access` because we have in the backlog story that would enable
to write following query:
```
SELECT * FROM Rates('2017/06/14 14:23:12`);
```
Otherwise it would almost for sure drift out of sync :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Support versioned joins in planning phase
> -----------------------------------------
>
> Key: FLINK-9713
> URL: https://issues.apache.org/jira/browse/FLINK-9713
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Affects Versions: 1.5.0
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: pull-request-available
>
> Queries like:
> {code:java}
> SELECT
> o.amount * r.rate
> FROM
> Orders AS o,
> LATERAL TABLE (Rates(o.rowtime)) AS r
> WHERE o.currency = r.currency{code}
> should evaluate to valid plan with versioned joins plan node.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
