[
https://issues.apache.org/jira/browse/FLINK-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14692814#comment-14692814
]
ASF GitHub Bot commented on FLINK-2512:
---------------------------------------
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/1009
[FLINK-2512]Add client.close() before throw RuntimeException
In line 129, it close client in finally{} before throw exception.
But in line 105, it throw exception without close client.
So I think it is better to close client before throw RuntimeException.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ffbin/flink FLINK-2512
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1009.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1009
----
commit 7510fdb6a8a082d8be85ba7968e9e2760edf2af0
Author: ffbin <[email protected]>
Date: 2015-08-12T02:06:21Z
[FLINK-2512]Add client.close() before throw RuntimeException
----
> Add client.close() before throw RuntimeException
> ------------------------------------------------
>
> Key: FLINK-2512
> URL: https://issues.apache.org/jira/browse/FLINK-2512
> Project: Flink
> Issue Type: Bug
> Components: flink-contrib
> Affects Versions: 0.8.1
> Reporter: fangfengbin
> Assignee: fangfengbin
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
