[
https://issues.apache.org/jira/browse/FLINK-2512?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693593#comment-14693593
]
ASF GitHub Bot commented on FLINK-2512:
---------------------------------------
Github user uce commented on the pull request:
https://github.com/apache/flink/pull/1009#issuecomment-130323420
If you move the try up, you can certainly remove the manual close.
Regarding the check in 103, it really depends on whether the Strom compat layer
depends on having only a single job per client. Therefore I would keep it in
and let it throw the RuntimeException as before. The finally block will then
make sure that the client is closed.
> Add client.close() before throw RuntimeException
> ------------------------------------------------
>
> Key: FLINK-2512
> URL: https://issues.apache.org/jira/browse/FLINK-2512
> Project: Flink
> Issue Type: Bug
> Components: flink-contrib
> Affects Versions: 0.8.1
> Reporter: fangfengbin
> Assignee: fangfengbin
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
