kleingeist commented on a change in pull request #6727: [FLINK-10371] Allow to
enable SSL mutual authentication on REST endpoints by configuration
URL: https://github.com/apache/flink/pull/6727#discussion_r220081405
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/net/SSLUtilsTest.java
##########
@@ -78,6 +78,29 @@ public void checkEnableSSL() {
assertFalse(SSLUtils.isRestSSLEnabled(precedence));
}
+ /**
+ * Tests whether activation of REST mutual SSL authentication evaluates
the config flags correctly.
+ */
+ @SuppressWarnings("deprecation")
Review comment:
the `SSL_ENABLED` option is deprecated, but using the annotation is a bad
way of handling this, I should rather use the new options, as the fallback is
already covered in another test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
