StefanRRichter commented on a change in pull request #6750: [FLINK-10402] Port
AbstractTaskManagerProcessFailureRecoveryTest to new code base
URL: https://github.com/apache/flink/pull/6750#discussion_r220230036
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
##########
@@ -397,7 +397,7 @@ private Configuration
generateClusterConfiguration(Configuration configuration)
return resultConfiguration;
}
- private CompletableFuture<ApplicationStatus> shutDownAsync(
+ public CompletableFuture<ApplicationStatus> shutDownAsync(
Review comment:
This method should be moved away from the comment section declaring
"internal methods" in this class. Or even better, instead of changing the
visibility of methods in this class, couldn't you expose them only through
`public static` helper methods in a class that is only in the test package like
`ClusterEntryPointTestUtils.startCluster(ClusterEntryPoint ep)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
