StefanRRichter commented on a change in pull request #6750: [FLINK-10402] Port
AbstractTaskManagerProcessFailureRecoveryTest to new code base
URL: https://github.com/apache/flink/pull/6750#discussion_r220965813
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
##########
@@ -397,7 +397,7 @@ private Configuration
generateClusterConfiguration(Configuration configuration)
return resultConfiguration;
}
- private CompletableFuture<ApplicationStatus> shutDownAsync(
+ public CompletableFuture<ApplicationStatus> shutDownAsync(
Review comment:
Hmm, I would leave that call up to you. My feeling is when somebody receives
a reference of this class that is not allowed to call `shutDownAsync`, I would
better not make it public at all to prevent that clients call it accidentally.
If that is not the case, yes why not use the interface that we have for the
concept.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
