[
https://issues.apache.org/jira/browse/FLINK-10406?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16627806#comment-16627806
]
tison edited comment on FLINK-10406 at 9/25/18 7:28 PM:
--------------------------------------------------------
* {{testStopSignal}} and {{testStopSignalFail}} are covered by
{{ExecutionGraphStopTest}}. High level invocation at {{Dispatcher}} and
{{JobMaster}} level are trivial.
* {{testNullHostnameGoesToLocalhost}} is ported to {{AkkaUtilsTest#"null
hostname should go to localhost"}}
* {{testRequestPartitionState*}} I would propose to ignore all of them since
we have FLINK-10319. It proposed to disable {{JobMaster#requestPartitionState}}
and have one approval and no objection yet. Also cc [[email protected]],
could you take a look at FLINK-10319 so that we could make the decision of this
removal? (UPDATE: even without FLINK-10319 accepted, these tests should be
covered by {{JobMasterTest#testRequestPartitionState}} and {{TaskTest#...}})
was (Author: tison):
* {{testStopSignal}} and {{testStopSignalFail}} are covered by
{{ExecutionGraphStopTest}}. High level invocation at {{Dispatcher}} and
{{JobMaster}} level are trivial.
* {{testNullHostnameGoesToLocalhost}} is ported to {{AkkaUtilsTest#"null
hostname should go to localhost"}}
* {{testRequestPartitionState*}} I would propose to ignore all of them since
we have FLINK-10319. It proposed to disable {{JobMaster#requestPartitionState}}
and have one approval and no objection yet. Also cc [[email protected]],
could you take a look at FLINK-10319 so that we could make the decision of this
removal?
> Port JobManagerTest to new code base
> ------------------------------------
>
> Key: FLINK-10406
> URL: https://issues.apache.org/jira/browse/FLINK-10406
> Project: Flink
> Issue Type: Sub-task
> Components: Tests
> Affects Versions: 1.7.0
> Reporter: tison
> Assignee: tison
> Priority: Major
> Fix For: 1.7.0
>
>
> Port {{JobManagerTest}} to new code base
> Not all of its tests should be ported, since some of them are covered by
> {{JobMasterTest}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
