[
https://issues.apache.org/jira/browse/FLINK-1819?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14693899#comment-14693899
]
ASF GitHub Bot commented on FLINK-1819:
---------------------------------------
Github user sachingoel0101 commented on the pull request:
https://github.com/apache/flink/pull/966#issuecomment-130384903
Oh apologies. I only saw the first comment on the email thread. I guess
it's more or less settled. I'll leave it up to you guys to make a final
decision on this. :')
On Aug 12, 2015 10:59 PM, "Sachin Goel" <sachingoel0...@gmail.com> wrote:
> I agree with Stephan's argument that addition of context to I/O formats is
> a very marginal enhancement. He literally stole my words. :')
> However, from my perspective, when I first started using flink, Rich meant
> runtime context. The idea of open and close wasn't as nearly exciting as
> the runtime context.
> What if we changed back to the original name mentioned on jira and make it
> `ContextAwareInputFormat`? Would everyone be okay with that?
> On Aug 12, 2015 8:10 PM, "Stephan Ewen" <notificati...@github.com> wrote:
>
>> Functions also need to extend RichFunction to have access to open() and
>> close().
>> I think the two things a different enough that any strife for
>> "consistency" is actually pretty "random".
>> If your thoughts currently revolve around the RuntimeContext, it apprears
>> more consistent. If you thoughts are on the life cycle methods, it seems
>> inconsistent. Random.
>>
>> I think you should go ahead and just call them "Rich". It is just a name,
>> and what matters is that the JavaDocs describe what it actually means...
>>
>> —
>> Reply to this email directly or view it on GitHub
>> <https://github.com/apache/flink/pull/966#issuecomment-130324909>.
>>
>
> Allow access to RuntimeContext from Input and OutputFormats
> -----------------------------------------------------------
>
> Key: FLINK-1819
> URL: https://issues.apache.org/jira/browse/FLINK-1819
> Project: Flink
> Issue Type: Improvement
> Components: Local Runtime
> Affects Versions: 0.9, 0.8.1
> Reporter: Fabian Hueske
> Assignee: Sachin Goel
> Priority: Minor
> Fix For: 0.9
>
>
> User function that extend a RichFunction can access a {{RuntimeContext}}
> which gives the parallel id of the task and access to Accumulators and
> BroadcastVariables.
> Right now, Input and OutputFormats cannot access their {{RuntimeContext}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
