[
https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14694938#comment-14694938
]
ASF GitHub Bot commented on FLINK-2490:
---------------------------------------
Github user mxm commented on a diff in the pull request:
https://github.com/apache/flink/pull/992#discussion_r36955316
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/api/functions/source/SocketTextStreamFunction.java
---
@@ -85,11 +84,12 @@ public void streamFromSocket(SourceContext<String> ctx,
Socket socket) throws Ex
}
}
- if (data == -1) {
+ if (data == null) {
socket.close();
long retry = 0;
boolean success = false;
- while (retry < maxRetry && !success) {
+ while ((retry < maxRetry ||
(retryForever && !isExit)) && !success) {
+ isRetrying = true;
--- End diff --
This flag is only necessary for your test and thus should be removed.
> Remove unwanted boolean check in function
> SocketTextStreamFunction.streamFromSocket
> -----------------------------------------------------------------------------------
>
> Key: FLINK-2490
> URL: https://issues.apache.org/jira/browse/FLINK-2490
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 0.10
> Reporter: Huang Wei
> Priority: Minor
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
