[
https://issues.apache.org/jira/browse/FLINK-2490?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14695133#comment-14695133
]
ASF GitHub Bot commented on FLINK-2490:
---------------------------------------
Github user mxm commented on the pull request:
https://github.com/apache/flink/pull/992#issuecomment-130644950
`StringBuilder` is only for single-threaded while `StringBuffer` enables
multi-thread access. If you use `StringBuffer` in a single-threaded scenario it
has worse performance than `StringBuilder`.
Thanks for you changes. In addition to the "infinity" test, can you add a
test that checks for a certain number of retries (e.g. 10)? Also please add a
check for 1 and 0 retries. It's always good to test corner cases :)
> Remove unwanted boolean check in function
> SocketTextStreamFunction.streamFromSocket
> -----------------------------------------------------------------------------------
>
> Key: FLINK-2490
> URL: https://issues.apache.org/jira/browse/FLINK-2490
> Project: Flink
> Issue Type: Bug
> Components: Streaming
> Affects Versions: 0.10
> Reporter: Huang Wei
> Priority: Minor
> Fix For: 0.10
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
