[ 
https://issues.apache.org/jira/browse/FLINK-10247?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16631432#comment-16631432
 ] 

ASF GitHub Bot commented on FLINK-10247:
----------------------------------------

yanghua commented on a change in pull request #6759: [FLINK-10247][Metrics] Run 
MetricQueryService in a dedicated actor system
URL: https://github.com/apache/flink/pull/6759#discussion_r221153905
 
 

 ##########
 File path: docs/_includes/generated/job_manager_configuration.html
 ##########
 @@ -27,6 +27,11 @@
             <td style="word-wrap: break-word;">"1024m"</td>
             <td>JVM heap size for the JobManager.</td>
         </tr>
+        <tr>
+            <td><h5>jobmanager.metric-query-service.rpc.port</h5></td>
+            <td style="word-wrap: break-word;">6124</td>
+            <td>The config parameter defining the network port to connect to 
for communication with the job manager's metric query service. Like 
jobmanager.rpc.address, this value is only interpreted in setups where a single 
JobManager with static name/address and port exists (simple standalone setups, 
or container setups with dynamic service name resolution). This config option 
is not used in many high-availability setups, when a leader-election service 
(like ZooKeeper) is used to elect and discover the JobManager leader from 
potentially multiple standby JobManagers.</td>
 
 Review comment:
   remove `to connect to`? It looks like there is a grammar problem, I am not 
sure

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Run MetricQueryService in separate thread pool
> ----------------------------------------------
>
>                 Key: FLINK-10247
>                 URL: https://issues.apache.org/jira/browse/FLINK-10247
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Metrics
>    Affects Versions: 1.5.3, 1.6.0, 1.7.0
>            Reporter: Till Rohrmann
>            Assignee: Shimin Yang
>            Priority: Critical
>              Labels: pull-request-available
>             Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> In order to make the {{MetricQueryService}} run independently of the main 
> Flink components, it should get its own dedicated thread pool assigned.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to