[
https://issues.apache.org/jira/browse/FLINK-10386?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16638424#comment-16638424
]
ASF GitHub Bot commented on FLINK-10386:
----------------------------------------
TisonKun commented on issue #6729: [FLINK-10386] [taskmanager] Remove legacy
class TaskExecutionStateListener
URL: https://github.com/apache/flink/pull/6729#issuecomment-427071700
All "Why are we removing these assertions?" is as you say, we do not send
those state updates via `TaskManagerActions.updateTaskExecutionState`. Maybe we
can verify
`TaskManagerActions.notifyFatalError`/`TaskManagerActions.failTask`/`TaskManagerActions.notifyFinalState`
but all of them don't include detail task state.
Besides, as the communication with @Clarkkkkk , `TaskTest` is a test based
on legacy mode, there is a pull request #6778 to port it to FLIP-6 code base.
I think the main issue is whether we replace `notifyObservers` with
`TaskManagerActions.updateTaskExecutionState`. My opinion is not for now to
hold the current(FLIP-6) message flow and defer the decision later. If so, we
remove those assertion because we don't send those message and the assertion
should not hold.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove legacy class TaskExecutionStateListener
> ----------------------------------------------
>
> Key: FLINK-10386
> URL: https://issues.apache.org/jira/browse/FLINK-10386
> Project: Flink
> Issue Type: Sub-task
> Components: TaskManager
> Affects Versions: 1.7.0
> Reporter: tison
> Assignee: tison
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> After a discussion
> [here|https://github.com/apache/flink/commit/0735b5b935b0c0757943e2d58047afcfb9949560#commitcomment-30584257]
> with [[email protected]]. I start to analyze the usage of
> {{ActorGatewayTaskExecutionStateListener}} and {{TaskExecutionStateListener}}.
> In conclusion, we abort {{TaskExecutionStateListener}} strategy and no any
> component rely on it. Instead, we introduce {{TaskManagerActions}} to take
> the role for the communication of {{Task}} with {{TaskManager}}. No one
> except {{TaskManager}} should directly communicate with {{Task}}. So it can
> be safely remove legacy class {{TaskExecutionStateListener}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
