Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics]
Run MetricQueryService in a dedicated actor system
URL: https://github.com/apache/flink/pull/6759#discussion_r222880719
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/entrypoint/ClusterEntrypoint.java
##########
@@ -252,6 +256,13 @@ protected void initializeServices(Configuration
configuration) throws Exception
configuration.setString(JobManagerOptions.ADDRESS,
commonRpcService.getAddress());
configuration.setInteger(JobManagerOptions.PORT,
commonRpcService.getPort());
+ final String metricPortRange =
getMetricQueryServiceRPCPortRange(configuration);
+ metricQueryRpcService = createRpcService(
Review comment:
I was trying to reuse the RPC service, seems like it's not necessary
actually. I will do the refactor here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
