Clarkkkkk commented on a change in pull request #6759: [FLINK-10247][Metrics]
Run MetricQueryService in a dedicated actor system
URL: https://github.com/apache/flink/pull/6759#discussion_r222880965
##########
File path:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala
##########
@@ -205,23 +242,34 @@ object AkkaUtils {
val supervisorStrategy =
classOf[StoppingSupervisorWithoutLoggingActorKilledExceptionStrategy]
.getCanonicalName
- val forkJoinExecutorParallelismFactor =
-
configuration.getDouble(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_FACTOR)
-
- val forkJoinExecutorParallelismMin =
- configuration.getInteger(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_MIN)
-
- val forkJoinExecutorParallelismMax =
- configuration.getInteger(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_MAX)
-
- val forkJoinExecutorConfig =
- s"""
- | fork-join-executor {
- | parallelism-factor = $forkJoinExecutorParallelismFactor
- | parallelism-min = $forkJoinExecutorParallelismMin
- | parallelism-max = $forkJoinExecutorParallelismMax
- | }
- """.stripMargin
+ val executorConfig= executorMode match {
+ case AkkaExecutorMode.FORK_JOIN_EXECUTOR =>
+ val forkJoinExecutorParallelismFactor =
+
configuration.getDouble(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_FACTOR)
+
+ val forkJoinExecutorParallelismMin =
+
configuration.getInteger(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_MIN)
+
+ val forkJoinExecutorParallelismMax =
+
configuration.getInteger(AkkaOptions.FORK_JOIN_EXECUTOR_PARALLELISM_MAX)
+
+ s"""
+ | fork-join-executor {
+ | parallelism-factor = $forkJoinExecutorParallelismFactor
+ | parallelism-min = $forkJoinExecutorParallelismMin
+ | parallelism-max = $forkJoinExecutorParallelismMax
+ | }
+ """.stripMargin
+
+ case AkkaExecutorMode.SINGLE_THREAD_EXECUTOR =>
+ s"""
+ | single-thread-executor {
+ | executor = "thread-pool-executor"
+ | type = PinnedDispatcher
+ | threads-priority = ${Thread.MIN_PRIORITY}
+ | }
+ """.stripMargin
+ }
Review comment:
Good point.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
