dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state
backends] Remove serializers from checkpoints
URL: https://github.com/apache/flink/pull/6711#discussion_r223313725
##########
File path:
flink-core/src/test/java/org/apache/flink/api/common/typeutils/TypeSerializerSerializationUtilTest.java
##########
@@ -182,15 +178,17 @@ public void testSerializeConfigurationSnapshots() throws
Exception {
public void testFailsWhenConfigurationSnapshotClassNotFound() throws
Exception {
byte[] serializedConfig;
try (ByteArrayOutputStream out = new ByteArrayOutputStream()) {
-
TypeSerializerSerializationUtil.writeSerializerConfigSnapshot(
- new DataOutputViewStreamWrapper(out), new
TypeSerializerSerializationUtilTest.TestConfigSnapshot(123, "foobar"));
+
TypeSerializerSnapshotSerializationUtil.writeSerializerSnapshot(
+ new DataOutputViewStreamWrapper(out),
+ new
TypeSerializerSerializationUtilTest.TestConfigSnapshot<>(123, "foobar"),
+ StringSerializer.INSTANCE);
serializedConfig = out.toByteArray();
}
try (ByteArrayInputStream in = new
ByteArrayInputStream(serializedConfig)) {
// read using a dummy classloader
-
TypeSerializerSerializationUtil.readSerializerConfigSnapshot(
- new DataInputViewStreamWrapper(in), new
URLClassLoader(new URL[0], null));
+
TypeSerializerSnapshotSerializationUtil.readSerializerSnapshot(
+ new DataInputViewStreamWrapper(in), new
URLClassLoader(new URL[0], null), null);
fail("Expected a ClassNotFoundException wrapped in
IOException");
Review comment:
Could we move the combination of `fail` and `catch` to
`@Test(expected=IOException.class)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
