dawidwys commented on a change in pull request #6711: [FLINK-9377] [core, state 
backends] Remove serializers from checkpoints
URL: https://github.com/apache/flink/pull/6711#discussion_r223689536
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/state/KeyedBackendSerializationProxy.java
 ##########
 @@ -44,7 +47,17 @@
  */
 public class KeyedBackendSerializationProxy<K> extends 
VersionedIOReadableWritable {
 
-       public static final int VERSION = 5;
+       public static final int VERSION = 6;
+
+       private static final Map<Integer, Integer> 
META_INFO_SNAPSHOT_FORMAT_VERSION_MAPPER = new HashMap<>();
+       static {
 
 Review comment:
   Agree we should keep track of the mapping. I just felt we could improve the 
clarity of the tracking even a bit more, but I could not think of a better 
solution right now. But as I said I think we could try make it a bit more 
straightforward in some follow-up.
   
   Just to sum it up. I think it is absolutely ok for this PR, but I have a 
feeling we could improve readability of this mapping **even more** in the 
future.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to