[
https://issues.apache.org/jira/browse/FLINK-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14697308#comment-14697308
]
ASF GitHub Bot commented on FLINK-2486:
---------------------------------------
Github user StephanEwen commented on the pull request:
https://github.com/apache/flink/pull/989#issuecomment-131165838
Sorry for catching this so late.
I actually put such "sanity checks" in a lot of places in the code I write,
and they have served well.
In the case where everything is all right, they are not necessary.
As soon as someone changes the code that calls this function (may happen in
the future), this can help catching bugs (fail fast principle).
I would like to keep such checks, they really do not hurt, and possibly
help in the future.
> Remove unwanted null check in removeInstance function
> -----------------------------------------------------
>
> Key: FLINK-2486
> URL: https://issues.apache.org/jira/browse/FLINK-2486
> Project: Flink
> Issue Type: Bug
> Components: Scheduler
> Affects Versions: 0.8.1
> Reporter: fangfengbin
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
