[
https://issues.apache.org/jira/browse/FLINK-2486?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14654709#comment-14654709
]
ASF GitHub Bot commented on FLINK-2486:
---------------------------------------
GitHub user ffbin opened a pull request:
https://github.com/apache/flink/pull/989
[FLINK-2486]Remove unwanted null check in removeInstance function
removeInstance() is called in
getFreeSlotForTask()/getNewSlotForSharingGroup()/handleNewSlot()/instanceDied()/newInstanceAvailable().
1.getFreeSlotForTask()/getNewSlotForSharingGroup()/handleNewSlot() only
catch InstanceDiedException, if instance is null, removeInstance() will not
work.
2.instanceDied()/newInstanceAvailable() has check instance ant the head of
function,so the instance parameter of removeInstance() is not null.
So null check of instance in removeInstance() is unwanted.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ffbin/flink FLINK-2486
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/989.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #989
----
commit 32c81aef41a46b47b591b04cb20914a32ddac9b8
Author: ffbin <[email protected]>
Date: 2015-08-05T01:48:51Z
[FLINK-2486]Remove unwanted null check in removeInstance function
----
> Remove unwanted null check in removeInstance function
> -----------------------------------------------------
>
> Key: FLINK-2486
> URL: https://issues.apache.org/jira/browse/FLINK-2486
> Project: Flink
> Issue Type: Bug
> Components: Scheduler
> Affects Versions: 0.8.1
> Reporter: fangfengbin
> Priority: Minor
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
