[
https://issues.apache.org/jira/browse/FLINK-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642745#comment-16642745
]
ASF GitHub Bot commented on FLINK-8581:
---------------------------------------
zhijiangW commented on a change in pull request #6698: [FLINK-8581][network]
Move flushing remote subpartitions from OutputFlusher to netty
URL: https://github.com/apache/flink/pull/6698#discussion_r223550777
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/partition/PipelinedSubpartition.java
##########
@@ -77,6 +77,14 @@ public void flush() {
}
}
+ @Override
+ public void registerPeriodicFlush(long flushTimeout) {
Review comment:
1. The behavior of this method may be simple like `notifyDataAvailable`? So
we can reduce `synchronized` part.
```
if (readView != null) {
readView. registerPeriodicFlush(flushTimeout);
}
```
2. This implementation is same in
`SpillableSubpartition#registerPeriodicFlush`, how about implementing this
method in the parent `ResultSubpartition#registerPeriodicFlush`? And the
relevant change is also defining protected `readView` in `ResultSubpartition`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Improve performance for low latency network
> -------------------------------------------
>
> Key: FLINK-8581
> URL: https://issues.apache.org/jira/browse/FLINK-8581
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.5.0
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
