[
https://issues.apache.org/jira/browse/FLINK-8581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642875#comment-16642875
]
ASF GitHub Bot commented on FLINK-8581:
---------------------------------------
zhijiangW commented on a change in pull request #6698: [FLINK-8581][network]
Move flushing remote subpartitions from OutputFlusher to netty
URL: https://github.com/apache/flink/pull/6698#discussion_r223575788
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/CreditBasedSequenceNumberingViewReader.java
##########
@@ -115,8 +115,12 @@ public boolean isRegisteredAsAvailable() {
@Override
public boolean isAvailable() {
// BEWARE: this must be in sync with
#isAvailable(BufferAndBacklog)!
- return hasBuffersAvailable() &&
- (numCreditsAvailable > 0 ||
subpartitionView.nextBufferIsEvent());
+ return hasBuffersAvailable() && !isBlocked();
+ }
+
+ @Override
+ public boolean isBlocked() {
Review comment:
I think the `isBlocked` naming can not indicate the specific semantics. How
about changing to `isCreditsAvailable()` directly?
To do so, the `isAvailable()` breaks into `buffersAvailable()` and
`creditsAvailable()`, and the following private method
`isAvailable(BufferAndBacklog bufferAndBacklog)` may also reuse
`isCreditsAvailable()` .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Improve performance for low latency network
> -------------------------------------------
>
> Key: FLINK-8581
> URL: https://issues.apache.org/jira/browse/FLINK-8581
> Project: Flink
> Issue Type: Improvement
> Components: Network
> Affects Versions: 1.5.0
> Reporter: Piotr Nowojski
> Assignee: Piotr Nowojski
> Priority: Major
> Labels: pull-request-available
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
