Github user sachingoel0101 commented on a diff in the pull request:
https://github.com/apache/flink/pull/970#discussion_r37144194
--- Diff:
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
---
@@ -897,7 +897,7 @@ class TaskManager(
config.timeout,
libCache,
fileCache,
- runtimeInfo)
+ new TaskRuntimeInfo(hostname, taskManagerConfig,
tdd.getAttemptNumber))
--- End diff --
Yes. The addition of distributed cache removes the need for multiple
constructors for `RuntimeContext`s. Since providing access to runtime
information needed changing the constructors, I deemed it better to work with
what would be the only needed constructors after merging this.
I can revert this commit and open a separate PR for the *other* three
issues if necessary.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
