[ 
https://issues.apache.org/jira/browse/FLINK-2458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14698610#comment-14698610
 ] 

ASF GitHub Bot commented on FLINK-2458:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/970#discussion_r37144275
  
    --- Diff: 
flink-runtime/src/main/scala/org/apache/flink/runtime/taskmanager/TaskManager.scala
 ---
    @@ -897,7 +897,7 @@ class TaskManager(
             config.timeout,
             libCache,
             fileCache,
    -        runtimeInfo)
    +        new TaskRuntimeInfo(hostname, taskManagerConfig, 
tdd.getAttemptNumber))
    --- End diff --
    
    I would prefer if you opened a second PR once this is merged. The issues 
are not really related to each other; the 2nd commit was simply made based on 
the 1st commit. We would end up having two separate discussions in 1 PR, which 
i think is a bad idea.


> Distributed Cache doesn't work with iterations.
> -----------------------------------------------
>
>                 Key: FLINK-2458
>                 URL: https://issues.apache.org/jira/browse/FLINK-2458
>             Project: Flink
>          Issue Type: Bug
>            Reporter: Sachin Goel
>            Assignee: Sachin Goel
>
> Distributed cache files cannot be accessed when working in Iterative 
> contexts. While constructing the context in {{AbstractIterativePactTask}}, 
> the distributed entries are not passed on to runtime context.
> My commit will add this and also unify the distributed cache system to work 
> everywhere, including in the Collection Environment.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to