zentol commented on a change in pull request #6850: [FLINK-10252] Handle
oversized metric messges
URL: https://github.com/apache/flink/pull/6850#discussion_r225473977
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/dump/MetricQueryService.java
##########
@@ -70,6 +72,17 @@ public String filterCharacters(String input) {
private final Map<Histogram, Tuple2<QueryScopeInfo, String>> histograms
= new HashMap<>();
private final Map<Meter, Tuple2<QueryScopeInfo, String>> meters = new
HashMap<>();
+ private long maximumFramesize;
+
+ @Override
+ public void preStart() throws Exception {
+ if
(getContext().system().settings().config().hasPath(MAXIMUM_FRAME_SIZE_PATH)) {
Review comment:
keep it then, but also copy the comment for the else branch since it is
important.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
