zentol commented on a change in pull request #6850: [FLINK-10252] Handle
oversized metric messges
URL: https://github.com/apache/flink/pull/6850#discussion_r226050176
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/metrics/MetricRegistryImpl.java
##########
@@ -90,7 +92,9 @@
/**
* Creates a new MetricRegistry and starts the configured reporter.
*/
- public MetricRegistryImpl(MetricRegistryConfiguration config) {
+ public MetricRegistryImpl(Configuration configuration) {
+ MetricRegistryConfiguration config =
MetricRegistryConfiguration.fromConfiguration(configuration);
Review comment:
the whole point of the `MetricRegistryConfiguration` is to not expose the
`Configuration` directly to the `MetricRegistry`. This should be reverted.
Instead, extend the MRConfiguration with a separate configuration object for
the akka stuff that the `MetricQueryService` requires, which btw. can be
determined before the actor is even started.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
