[
https://issues.apache.org/jira/browse/FLINK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16652565#comment-16652565
]
ASF GitHub Bot commented on FLINK-10253:
----------------------------------------
tillrohrmann commented on a change in pull request #6839: [FLINK-10253] Run
MetricQueryService with lower priority
URL: https://github.com/apache/flink/pull/6839#discussion_r225729531
##########
File path:
flink-runtime/src/main/scala/org/apache/flink/runtime/akka/AkkaUtils.scala
##########
@@ -291,12 +291,21 @@ object AkkaUtils {
ConfigFactory.parseString(config)
}
- def getThreadPoolExecutorConfig: Config = {
+ def getThreadPoolExecutorConfig(threadPriority: Int): Config = {
+ if (threadPriority < Thread.MIN_PRIORITY || threadPriority >
Thread.MAX_PRIORITY) {
+ throw new IllegalConfigurationException("The config : " +
+ MetricOptions.QUERY_SERVICE_THREAD_PRIORITY.key() + "'s value must
between "
+ + Thread.MIN_PRIORITY + " and " + Thread.MAX_PRIORITY +
+ ", but the value is " + threadPriority)
Review comment:
This should not refer to the `MetricOptions.QUERY_SERVICE_THREAD_PRIORITY`
option. Instead it should say that the `threadPriority` must be between
`Thread.MIN_PRIORITY` and `Thread.MAX_PRIORITY`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Run MetricQueryService with lower priority
> ------------------------------------------
>
> Key: FLINK-10253
> URL: https://issues.apache.org/jira/browse/FLINK-10253
> Project: Flink
> Issue Type: Sub-task
> Components: Metrics
> Affects Versions: 1.5.3, 1.6.0, 1.7.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> We should run the {{MetricQueryService}} with a lower priority than the main
> Flink components. An idea would be to start the underlying threads with a
> lower priority.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
