[
https://issues.apache.org/jira/browse/FLINK-10253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16653043#comment-16653043
]
ASF GitHub Bot commented on FLINK-10253:
----------------------------------------
tillrohrmann commented on a change in pull request #6839: [FLINK-10253] Run
MetricQueryService with lower priority
URL: https://github.com/apache/flink/pull/6839#discussion_r225794071
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/clusterframework/BootstrapTools.java
##########
@@ -290,7 +291,8 @@ private static Config
getExecutorConfigByExecutorMode(Configuration configuratio
case FORK_JOIN_EXECUTOR:
return
AkkaUtils.getForkJoinExecutorConfig(configuration);
case FIXED_THREAD_POOL_EXECUTOR:
- return AkkaUtils.getThreadPoolExecutorConfig();
+ return AkkaUtils.getThreadPoolExecutorConfig(
+
configuration.getInteger(MetricOptions.QUERY_SERVICE_THREAD_PRIORITY));
Review comment:
Good point. Only the thread priority should be passed to this method here. I
guess we need to introduce a executor config instead of simply using an enum.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Run MetricQueryService with lower priority
> ------------------------------------------
>
> Key: FLINK-10253
> URL: https://issues.apache.org/jira/browse/FLINK-10253
> Project: Flink
> Issue Type: Sub-task
> Components: Metrics
> Affects Versions: 1.5.3, 1.6.0, 1.7.0
> Reporter: Till Rohrmann
> Assignee: vinoyang
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.7.0, 1.6.2, 1.5.5
>
>
> We should run the {{MetricQueryService}} with a lower priority than the main
> Flink components. An idea would be to start the underlying threads with a
> lower priority.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
