[
https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654396#comment-16654396
]
ASF GitHub Bot commented on FLINK-10436:
----------------------------------------
TisonKun opened a new pull request #6872: [FLINK-10436] Add
ConfigOption#withFallbackKeys
URL: https://github.com/apache/flink/pull/6872
## What is the purpose of the change
Add `ConfigOption#withFallbackKeys` to implement a similar function with
`ConfigOption#withDeprecatedKeys`. That is, the `fallbackKey` falls back to
current key if it has not been specified, but the use of current key would not
print a deprecated message.
## Brief change log
- Introduce `FallbackKey` class to represent a key with `isDeprecated`
message.
- Replace `deprecatedKeys` to `fallbackKeys` in `ConfigOption`
## Verifying this change
- Add a test `ConfigurationTest#testFallbackKeys` to check the fallback
mechanism works.
- Manually check the issue report by the corresponding JIRA disappear.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: (yes)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
- If yes, how is the feature documented? (not applicable)
cc @tillrohrmann
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Example config uses deprecated key jobmanager.rpc.address
> ---------------------------------------------------------
>
> Key: FLINK-10436
> URL: https://issues.apache.org/jira/browse/FLINK-10436
> Project: Flink
> Issue Type: Sub-task
> Components: Startup Shell Scripts
> Affects Versions: 1.7.0
> Reporter: Ufuk Celebi
> Assignee: TisonKun
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The example {{flink-conf.yaml}} shipped as part of the Flink distribution
> (https://github.com/apache/flink/blob/master/flink-dist/src/main/resources/flink-conf.yaml)
> has the following entry:
> {code}
> jobmanager.rpc.address: localhost
> {code}
> When using this key, the following deprecation warning is logged.
> {code}
> 2018-09-26 12:01:46,608 WARN org.apache.flink.configuration.Configuration
> - Config uses deprecated configuration key
> 'jobmanager.rpc.address' instead of proper key 'rest.address'
> {code}
> The example config should not use deprecated config options.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
