[
https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16654958#comment-16654958
]
ASF GitHub Bot commented on FLINK-10436:
----------------------------------------
tillrohrmann commented on a change in pull request #6872: [FLINK-10436] Add
ConfigOption#withFallbackKeys
URL: https://github.com/apache/flink/pull/6872#discussion_r226239939
##########
File path:
flink-core/src/main/java/org/apache/flink/configuration/Configuration.java
##########
@@ -701,12 +701,14 @@ public boolean contains(ConfigOption<?> configOption) {
if (this.confData.containsKey(configOption.key())) {
return true;
}
- else if (configOption.hasDeprecatedKeys()) {
- // try the deprecated keys
- for (String deprecatedKey :
configOption.deprecatedKeys()) {
- if
(this.confData.containsKey(deprecatedKey)) {
- LOG.warn("Config uses
deprecated configuration key '{}' instead of proper key '{}'",
- deprecatedKey,
configOption.key());
+ else if (configOption.hasFallbackKeys()) {
+ // try the fallback keys
+ for (FallbackKey fallbackKey :
configOption.fallbackKeys()) {
+ if
(this.confData.containsKey(fallbackKey.getKey())) {
+ if (fallbackKey.isDeprecated())
{
Review comment:
Maybe it would be a good idea to log on `info` if we fall back to another
key if `fallbackKey.isDeprecated == false`. That way, the user knows from which
option it has read the value.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Example config uses deprecated key jobmanager.rpc.address
> ---------------------------------------------------------
>
> Key: FLINK-10436
> URL: https://issues.apache.org/jira/browse/FLINK-10436
> Project: Flink
> Issue Type: Sub-task
> Components: Startup Shell Scripts
> Affects Versions: 1.7.0
> Reporter: Ufuk Celebi
> Assignee: TisonKun
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The example {{flink-conf.yaml}} shipped as part of the Flink distribution
> (https://github.com/apache/flink/blob/master/flink-dist/src/main/resources/flink-conf.yaml)
> has the following entry:
> {code}
> jobmanager.rpc.address: localhost
> {code}
> When using this key, the following deprecation warning is logged.
> {code}
> 2018-09-26 12:01:46,608 WARN org.apache.flink.configuration.Configuration
> - Config uses deprecated configuration key
> 'jobmanager.rpc.address' instead of proper key 'rest.address'
> {code}
> The example config should not use deprecated config options.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
