[
https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656323#comment-16656323
]
ASF GitHub Bot commented on FLINK-10436:
----------------------------------------
zentol commented on issue #6872: [FLINK-10436] Add ConfigOption#withFallbackKeys
URL: https://github.com/apache/flink/pull/6872#issuecomment-431256748
> If we now introduce a RestOption#DISPATCHER_ADDRESS with the fallback to
RestOption#ADDRESS and JobManagerOptions#ADDRESS and remove the latter as a
deprecated key from the former, then we break setups.
> In the future, this might change and could require to remove the fallback
dependency depending on what the default behaviour is.
This also applies to your proposed solution for handling this issue in the
future.
Although ... is this really is an issue? We can change all usages within
Flink to `DISPATCHER_ADDRESS` (which should be reasonable considering that we
only ever go to the dispatcher via REST), with the exception of the
`RestServerEndpoint` for which we map ' DISPATCHER_ADDRESS' to ' REST#ADDRESS'.
What could this break?
I can only come up with a custom `ClusterEntryPoint` that uses a
`RestServerEndpoint` internally and no other Flink component that is aware of
the configuration thingie, which seems unlikely?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Example config uses deprecated key jobmanager.rpc.address
> ---------------------------------------------------------
>
> Key: FLINK-10436
> URL: https://issues.apache.org/jira/browse/FLINK-10436
> Project: Flink
> Issue Type: Sub-task
> Components: Startup Shell Scripts
> Affects Versions: 1.7.0
> Reporter: Ufuk Celebi
> Assignee: TisonKun
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The example {{flink-conf.yaml}} shipped as part of the Flink distribution
> (https://github.com/apache/flink/blob/master/flink-dist/src/main/resources/flink-conf.yaml)
> has the following entry:
> {code}
> jobmanager.rpc.address: localhost
> {code}
> When using this key, the following deprecation warning is logged.
> {code}
> 2018-09-26 12:01:46,608 WARN org.apache.flink.configuration.Configuration
> - Config uses deprecated configuration key
> 'jobmanager.rpc.address' instead of proper key 'rest.address'
> {code}
> The example config should not use deprecated config options.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
