[
https://issues.apache.org/jira/browse/FLINK-10436?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16656444#comment-16656444
]
ASF GitHub Bot commented on FLINK-10436:
----------------------------------------
tillrohrmann commented on issue #6872: [FLINK-10436] Add
ConfigOption#withFallbackKeys
URL: https://github.com/apache/flink/pull/6872#issuecomment-431287759
I could imagine a custom HTTP client used to query the REST endpoint which
relies on `RestOptions#ADDRESS`. Admittedly, the `RestOptions` are marked as
`@Internal` though.
Yes, at some point I guess we have to break the behaviour.
However, I think we are derailing the discussion a bit and widening the
scope of this issue. The issue is intended to solve the problem that we log
warnings when falling back to the `JobManagerOptions#ADDRESS`. The dependency
of `RestOptions#ADDRESS` on `JobManagerOptions#ADDRESS` is not intended to be
resolved in the scope of this issue. I think the changes of this PR do not make
things worse and indeed solve the problem of deprecation warnings.
Consequently, I would suggest that we address the disentanglement in a separate
issue. What do you think @zentol?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Example config uses deprecated key jobmanager.rpc.address
> ---------------------------------------------------------
>
> Key: FLINK-10436
> URL: https://issues.apache.org/jira/browse/FLINK-10436
> Project: Flink
> Issue Type: Sub-task
> Components: Startup Shell Scripts
> Affects Versions: 1.7.0
> Reporter: Ufuk Celebi
> Assignee: TisonKun
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
> The example {{flink-conf.yaml}} shipped as part of the Flink distribution
> (https://github.com/apache/flink/blob/master/flink-dist/src/main/resources/flink-conf.yaml)
> has the following entry:
> {code}
> jobmanager.rpc.address: localhost
> {code}
> When using this key, the following deprecation warning is logged.
> {code}
> 2018-09-26 12:01:46,608 WARN org.apache.flink.configuration.Configuration
> - Config uses deprecated configuration key
> 'jobmanager.rpc.address' instead of proper key 'rest.address'
> {code}
> The example config should not use deprecated config options.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
