ifndef-SleePy commented on a change in pull request #6770: [FLINK-10002]
[Webfrontend] WebUI shows jm/tm logs more friendly.
URL: https://github.com/apache/flink/pull/6770#discussion_r226521972
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/resourcemanager/ResourceManager.java
##########
@@ -622,7 +628,19 @@ public void unRegisterInfoMessageListener(final String
address) {
log.debug("Requested file {} upload from unregistered
TaskExecutor {}.", fileType, taskManagerId);
return FutureUtils.completedExceptionally(new
UnknownTaskExecutorException(taskManagerId));
} else {
- return
taskExecutor.getTaskExecutorGateway().requestFileUpload(fileType, timeout);
+ return
taskExecutor.getTaskExecutorGateway().requestFileUpload(fileType, timeout,
filename, range);
+ }
+ }
+
+ @Override
+ public CompletableFuture<String[]> requestTaskManagerLogList(ResourceID
taskManagerId, Time timeout){
+ log.debug("Request historical loglist from TaskExecutor {}.",
taskManagerId);
Review comment:
Log would be too much, I think we should avoid debug log in normal code path.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
