NicoK commented on issue #6705: [FLINK-10356][network] add sanity checks to 
SpillingAdaptiveSpanningRecordDeserializer
URL: https://github.com/apache/flink/pull/6705#issuecomment-431833695
 
 
   Thanks for the review @zhijiangW. The `getDeserializationError()` method was 
indeed a bit hacky and misleading. I refactored the code so it is (hopefully) 
clearer but anyway easier to maintain.
   
   I hope you can continue the review with the tests so we can still get this 
into 1.7.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to