NicoK commented on issue #6705: [FLINK-10356][network] add sanity checks to 
SpillingAdaptiveSpanningRecordDeserializer
URL: https://github.com/apache/flink/pull/6705#issuecomment-432180676
 
 
   thanks again @zhijiangW - I updated the tests accordingly.
   
   Regarding performance: there may be a penalty from these checks but it is 
actually not much work after all: we are just comparing indices. Anyway, I 
think, the additional safety here is worth a potential performance impact.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to