[
https://issues.apache.org/jira/browse/FLINK-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659396#comment-16659396
]
ASF GitHub Bot commented on FLINK-7811:
---------------------------------------
zentol commented on a change in pull request #6894: [FLINK-7811] Add support
for Scala 2.12
URL: https://github.com/apache/flink/pull/6894#discussion_r226986787
##########
File path: flink-formats/flink-json/pom.xml
##########
@@ -70,17 +69,24 @@ under the License.
<dependency>
<groupId>org.apache.flink</groupId>
- <!-- use a dedicated Scala version to not depend on it
-->
- <artifactId>flink-table_2.11</artifactId>
+
<artifactId>flink-table_${scala.binary.version}</artifactId>
<version>${project.version}</version>
<type>test-jar</type>
<scope>test</scope>
</dependency>
- <!-- flink-table needs Scala -->
+ <!-- flink-table needs these -->
<dependency>
<groupId>org.scala-lang</groupId>
- <artifactId>scala-compiler</artifactId>
+ <artifactId>scala-library</artifactId>
+ <scope>test</scope>
+ </dependency>
+ <!-- the reason things normally work out without this is that
this is a transitive
Review comment:
this is a weird comment; doesn't that apply to all undeclared usages of
transitive dependencies?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add support for Scala 2.12
> --------------------------
>
> Key: FLINK-7811
> URL: https://issues.apache.org/jira/browse/FLINK-7811
> Project: Flink
> Issue Type: Sub-task
> Components: Scala API
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
