[
https://issues.apache.org/jira/browse/FLINK-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659382#comment-16659382
]
ASF GitHub Bot commented on FLINK-7811:
---------------------------------------
zentol commented on a change in pull request #6894: [FLINK-7811] Add support
for Scala 2.12
URL: https://github.com/apache/flink/pull/6894#discussion_r226971542
##########
File path: tools/releasing/deploy_staging_jars.sh
##########
@@ -41,5 +41,10 @@ cd ..
echo "Deploying to repository.apache.org"
echo "Deploying Scala 2.11 version"
+./change-scala-version.sh 2.11
$MVN clean deploy -Prelease,docs-and-source -DskipTests
-DretryFailedDeploymentCount=10
+echo "Deploying Scala 2.12 version"
+./change-scala-version.sh 2.12
Review comment:
The fact that the side-effects of this call aren't visible in the git
history concerns me a bit.
This effectively means that the release commit does _not_ correspond to the
deployed artifacts nor binary releases. This brings us into really murky
territory that I'd very much like to avoid, as it raises the question how to
determine (and verify!) what changes have been made to the artifacts/binaries
since the release commit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add support for Scala 2.12
> --------------------------
>
> Key: FLINK-7811
> URL: https://issues.apache.org/jira/browse/FLINK-7811
> Project: Flink
> Issue Type: Sub-task
> Components: Scala API
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
