[
https://issues.apache.org/jira/browse/FLINK-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659572#comment-16659572
]
ASF GitHub Bot commented on FLINK-7811:
---------------------------------------
StephanEwen commented on a change in pull request #6784: [FLINK-7811] Add
support for Scala 2.12
URL: https://github.com/apache/flink/pull/6784#discussion_r226954254
##########
File path:
flink-scala/src/main/scala/org/apache/flink/api/scala/unfinishedKeyPairOperation.scala
##########
@@ -90,6 +90,22 @@ private[flink] abstract class UnfinishedKeyPairOperation[L,
R, O](
val leftKey = new Keys.SelectorFunctionKeys[L, K](keyExtractor,
leftInput.getType, keyType)
new HalfUnfinishedKeyPairOperation[L, R, O](this, leftKey)
}
+
+ /**
+ * Specify the key selector function for the left side of the key based
operation. This returns
+ * a [[HalfUnfinishedKeyPairOperation]] on which `equalTo` must be called to
specify the
+ * key for the right side. The result after specifying the right side key is
the finished
+ * operation.
+ */
+ def where[K: TypeInformation](fun: KeySelector[L, K]) = {
+ val keyType = implicitly[TypeInformation[K]]
+ val keyExtractor = new KeySelector[L, K] {
Review comment:
This looks like redundant wrapping of `KeySelector` into `KeySelector`. I
would suggest to remove that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add support for Scala 2.12
> --------------------------
>
> Key: FLINK-7811
> URL: https://issues.apache.org/jira/browse/FLINK-7811
> Project: Flink
> Issue Type: Sub-task
> Components: Scala API
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
