[
https://issues.apache.org/jira/browse/FLINK-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659570#comment-16659570
]
ASF GitHub Bot commented on FLINK-7811:
---------------------------------------
StephanEwen commented on a change in pull request #6784: [FLINK-7811] Add
support for Scala 2.12
URL: https://github.com/apache/flink/pull/6784#discussion_r226954521
##########
File path:
flink-scala/src/main/scala/org/apache/flink/api/scala/unfinishedKeyPairOperation.scala
##########
@@ -140,6 +156,28 @@ private[flink] class HalfUnfinishedKeyPairOperation[L, R,
O](
keyExtractor,
unfinished.rightInput.getType,
keyType)
+
+ if (!leftKey.areCompatible(rightKey)) {
+ throw new InvalidProgramException("The types of the key fields do not
match. Left: " +
+ leftKey + " Right: " + rightKey)
+ }
+ unfinished.finish(leftKey, rightKey)
+ }
+
+ /**
+ * Specify the key selector function for the right side of the key based
operation. This returns
+ * the finished operation.
+ */
+ def equalTo[K: TypeInformation](fun: KeySelector[R, K]): O = {
+ val keyType = implicitly[TypeInformation[K]]
+ val keyExtractor = new KeySelector[R, K] {
Review comment:
Redundant wrapping, see above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Add support for Scala 2.12
> --------------------------
>
> Key: FLINK-7811
> URL: https://issues.apache.org/jira/browse/FLINK-7811
> Project: Flink
> Issue Type: Sub-task
> Components: Scala API
> Reporter: Aljoscha Krettek
> Assignee: Aljoscha Krettek
> Priority: Major
> Labels: pull-request-available
> Fix For: 1.7.0
>
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
