[ 
https://issues.apache.org/jira/browse/FLINK-7811?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16659609#comment-16659609
 ] 

ASF GitHub Bot commented on FLINK-7811:
---------------------------------------

StephanEwen commented on a change in pull request #6784: [FLINK-7811] Add 
support for Scala 2.12
URL: https://github.com/apache/flink/pull/6784#discussion_r227074756
 
 

 ##########
 File path: flink-libraries/flink-sql-client/pom.xml
 ##########
 @@ -45,22 +45,19 @@ under the License.
 
                <dependency>
                        <groupId>org.apache.flink</groupId>
-                       <!-- use a dedicated Scala version to not depend on it 
-->
 
 Review comment:
   I am puzzled by these dependencies. Why does the SQL client create an 
artifact that is not Scala versioned when it has "compile" dependencies on 
Scala-versioned artifacts? This seems like a problem in the current setup that 
is only not surfacing because there is only one Scala version. As soon as we 
support a second version, this will cause real problems with non-deterministic 
dependencies of released artifacts.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


> Add support for Scala 2.12
> --------------------------
>
>                 Key: FLINK-7811
>                 URL: https://issues.apache.org/jira/browse/FLINK-7811
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Scala API
>            Reporter: Aljoscha Krettek
>            Assignee: Aljoscha Krettek
>            Priority: Major
>              Labels: pull-request-available
>             Fix For: 1.7.0
>
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to