pnowojski commented on a change in pull request #6705: [FLINK-10356][network] 
add sanity checks to SpillingAdaptiveSpanningRecordDeserializer
URL: https://github.com/apache/flink/pull/6705#discussion_r227334044
 
 

 ##########
 File path: 
flink-runtime/src/main/java/org/apache/flink/runtime/io/network/api/serialization/SpillingAdaptiveSpanningRecordDeserializer.java
 ##########
 @@ -539,7 +568,7 @@ private void addNextChunkFromMemorySegment(MemorySegment 
segment, int offset, in
                                // there is more data in the segment
                                this.leftOverData = segment;
                                this.leftOverStart = segmentPosition + toCopy;
-                               this.leftOverLimit = numBytes + offset;
+                               this.leftOverLimit = offset + numBytes;
 
 Review comment:
   I see a very important bug fix here ( ;) )

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to