GJL opened a new pull request #6907: [FLINK-10357][tests] Improve StreamingFileSink E2E test stability. URL: https://github.com/apache/flink/pull/6907 ## What is the purpose of the change *Previously, we relied on checkpoint statistics to decide when to re-check the number of files written by the sink under test. However, side effects are triggered asynchronously, i.e., it can happen that statistics are updated before side effects are triggered (rolling of files). This can lead to test failures due to hash mismatches. We now wait until the number of expected lines were written to the file system.* ## Brief change log - *It is fairly obvious. Also see the commits.* ## Verifying this change This change added tests and can be verified as follows: - *I am changing a test. I ran the test, and it passes more often now.* ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no** / don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no** / don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
