[
https://issues.apache.org/jira/browse/FLINK-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16662421#comment-16662421
]
ASF GitHub Bot commented on FLINK-10613:
----------------------------------------
zentol opened a new pull request #6922: [FLINK-10613][hbase][tests] Remove
logger casts
URL: https://github.com/apache/flink/pull/6922
This PR removes some logger casts in the HBase IT case. The casting is only
used to increase the log-level, but this can be done more safely via the
`log4j-test.properties` file.
I do not modify the log4j properties in this PR since it seems unnecessary
in the first place. Chances are that someone trying to debug the code will just
get lost in a sea of trace messages from hbase.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove logger casts in HBaseConnectorITCase
> -------------------------------------------
>
> Key: FLINK-10613
> URL: https://issues.apache.org/jira/browse/FLINK-10613
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.4
> Reporter: Chesnay Schepler
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.5.6, 1.6.3, 1.7.0
>
>
> During the testing of {{1.5.5-rc1}} an issue was discovered in the
> {{HBaseConnectorITCase}} where a cast could fail if {{flink-table}} tests
> were previously executed, since in this case the {{jcl-over-slf4j}} bridge is
> being loaded.
> {code:java}
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=128m;
> support was removed in 8.0
> Running org.apache.flink.addons.hbase.HBaseConnectorITCase
> Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.557 sec <<<
> FAILURE! - in org.apache.flink.addons.hbase.HBaseConnectorITCase
> org.apache.flink.addons.hbase.HBaseConnectorITCase Time elapsed: 0.556 sec
> <<< ERROR!
> java.lang.ClassCastException:
> org.apache.commons.logging.impl.SLF4JLocationAwareLog cannot be cast to
> org.apache.commons.logging.impl.Log4JLogger
> org.apache.flink.addons.hbase.HBaseConnectorITCase Time elapsed: 0.557 sec
> <<< ERROR!
> java.lang.NullPointerException{code}
> While the logger-loading issue itself is rather subtle I believe the
> underlying issue to be the casts to set the log-level.
> It should be possible to enable said logging through the
> {{log4j-test.properties}} configuration instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
