[
https://issues.apache.org/jira/browse/FLINK-10613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16663611#comment-16663611
]
ASF GitHub Bot commented on FLINK-10613:
----------------------------------------
zentol closed pull request #6922: [FLINK-10613][hbase][tests] Remove logger
casts
URL: https://github.com/apache/flink/pull/6922
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/HBaseTestingClusterAutostarter.java
b/flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/HBaseTestingClusterAutostarter.java
index e4b2bd2fa3a..2e61a285330 100644
---
a/flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/HBaseTestingClusterAutostarter.java
+++
b/flink-connectors/flink-hbase/src/test/java/org/apache/flink/addons/hbase/HBaseTestingClusterAutostarter.java
@@ -24,7 +24,6 @@
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
-import org.apache.commons.logging.impl.Log4JLogger;
import org.apache.hadoop.conf.Configuration;
import org.apache.hadoop.hbase.HBaseConfiguration;
import org.apache.hadoop.hbase.HBaseTestingUtility;
@@ -36,10 +35,6 @@
import org.apache.hadoop.hbase.ZooKeeperConnectionException;
import org.apache.hadoop.hbase.client.HBaseAdmin;
import org.apache.hadoop.hbase.client.HTable;
-import org.apache.hadoop.hbase.client.ScannerCallable;
-import org.apache.hadoop.hbase.ipc.AbstractRpcClient;
-import org.apache.hadoop.hbase.ipc.RpcServer;
-import org.apache.log4j.Level;
import org.junit.AfterClass;
import org.junit.BeforeClass;
@@ -149,9 +144,6 @@ private static Configuration initialize(Configuration conf)
{
@BeforeClass
public static void setUp() throws Exception {
LOG.info("HBase minicluster: Starting");
- ((Log4JLogger) RpcServer.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger)
AbstractRpcClient.LOG).getLogger().setLevel(Level.ALL);
- ((Log4JLogger)
ScannerCallable.LOG).getLogger().setLevel(Level.ALL);
TEST_UTIL.startMiniCluster(1);
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Remove logger casts in HBaseConnectorITCase
> -------------------------------------------
>
> Key: FLINK-10613
> URL: https://issues.apache.org/jira/browse/FLINK-10613
> Project: Flink
> Issue Type: Improvement
> Components: Tests
> Affects Versions: 1.5.4
> Reporter: Chesnay Schepler
> Assignee: Chesnay Schepler
> Priority: Critical
> Labels: pull-request-available
> Fix For: 1.5.6, 1.6.3, 1.7.0
>
>
> During the testing of {{1.5.5-rc1}} an issue was discovered in the
> {{HBaseConnectorITCase}} where a cast could fail if {{flink-table}} tests
> were previously executed, since in this case the {{jcl-over-slf4j}} bridge is
> being loaded.
> {code:java}
> Java HotSpot(TM) 64-Bit Server VM warning: ignoring option MaxPermSize=128m;
> support was removed in 8.0
> Running org.apache.flink.addons.hbase.HBaseConnectorITCase
> Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.557 sec <<<
> FAILURE! - in org.apache.flink.addons.hbase.HBaseConnectorITCase
> org.apache.flink.addons.hbase.HBaseConnectorITCase Time elapsed: 0.556 sec
> <<< ERROR!
> java.lang.ClassCastException:
> org.apache.commons.logging.impl.SLF4JLocationAwareLog cannot be cast to
> org.apache.commons.logging.impl.Log4JLogger
> org.apache.flink.addons.hbase.HBaseConnectorITCase Time elapsed: 0.557 sec
> <<< ERROR!
> java.lang.NullPointerException{code}
> While the logger-loading issue itself is rather subtle I believe the
> underlying issue to be the casts to set the log-level.
> It should be possible to enable said logging through the
> {{log4j-test.properties}} configuration instead.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
