[
https://issues.apache.org/jira/browse/FLINK-10687?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16666974#comment-16666974
]
ASF GitHub Bot commented on FLINK-10687:
----------------------------------------
twalthr opened a new pull request #6958: [FLINK-10687] [table] Make
flink-formats Scala-free
URL: https://github.com/apache/flink/pull/6958
## What is the purpose of the change
This PR makes the `flink-formats` module Scala free by introducing a
`flink-table-common` module that is implemented in Java. This module contains
all classes that are required across different Maven modules.
## Brief change log
The following classes have been migrated to Java:
```
./src/test/java/org/apache/flink/table/descriptors/DescriptorTestBase.java
./src/test/java/org/apache/flink/table/factories/TableFormatFactoryBaseTest.java
./src/main/java/org/apache/flink/table/utils/TypeStringUtils.java
./src/main/java/org/apache/flink/table/utils/EncodingUtils.java
./src/main/java/org/apache/flink/table/descriptors/Descriptor.java
./src/main/java/org/apache/flink/table/descriptors/DescriptorBase.java
./src/main/java/org/apache/flink/table/descriptors/ConnectorDescriptorValidator.java
./src/main/java/org/apache/flink/table/descriptors/FormatDescriptor.java
./src/main/java/org/apache/flink/table/descriptors/DescriptorValidator.java
./src/main/java/org/apache/flink/table/descriptors/FormatDescriptorValidator.java
./src/main/java/org/apache/flink/table/descriptors/DescriptorProperties.java
./src/main/java/org/apache/flink/table/descriptors/ConnectorDescriptor.java
./src/main/java/org/apache/flink/table/factories/TableFactory.java
./src/main/java/org/apache/flink/table/factories/TableFormatFactory.java
./src/main/java/org/apache/flink/table/factories/DeserializationSchemaFactory.java
./src/main/java/org/apache/flink/table/factories/SerializationSchemaFactory.java
./src/main/java/org/apache/flink/table/factories/TableFormatFactoryBase.java
./src/main/java/org/apache/flink/table/api/ValidationException.java
./src/main/java/org/apache/flink/table/api/TableException.java
./src/main/java/org/apache/flink/table/api/TableSchema.java
```
Additionally, all classes in this module have been annotated with
`@Internal` and `@PublicEvolving` accordingly.
Since the methods in `Descriptor` were declared with `private[flink]`
visibility, they have been migrated to a new `toProperties()` method that is
public.
## Verifying this change
All existing tests are still successful.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): yes
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Yarn/Mesos, ZooKeeper: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? JavaDocs
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
> Make flink-formats Scala-free
> -----------------------------
>
> Key: FLINK-10687
> URL: https://issues.apache.org/jira/browse/FLINK-10687
> Project: Flink
> Issue Type: Sub-task
> Components: Table API & SQL
> Reporter: Timo Walther
> Assignee: Timo Walther
> Priority: Major
> Labels: pull-request-available
>
> {{flink-table}} is the only dependency that pulls in Scala for
> {{flink-json}}, {{flink-avro}}. We should aim to make {{flink-formats}}
> Scala-free using only a dependency to {{flink-table-common}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
